Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update Abseil library #14041

Merged
merged 4 commits into from
Nov 26, 2020
Merged

deps: update Abseil library #14041

merged 4 commits into from
Nov 26, 2020

Conversation

rojkov
Copy link
Member

@rojkov rojkov commented Nov 16, 2020

Commit Message: deps: update Abseil library
Additional Description: Also enforce linking with libc++ when sanitizers are enabled to resolve successfully symbols missing from gcc's c++ runtime.
Risk Level: Low
Testing: run integration tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
Fixes #13973

Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@intel.com>
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #14041 was opened by rojkov.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Nov 16, 2020
@moderation
Copy link
Contributor

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Nov 16, 2020
@rojkov
Copy link
Member Author

rojkov commented Nov 17, 2020

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #14041 (comment) was created by @rojkov.

see: more, trace.

@rojkov
Copy link
Member Author

rojkov commented Nov 17, 2020

@lizan It seems the clang-asan build can't link properly with libc++ from LLVM 7.0.1. If I drop --define boringssl=fips from COMPILE_TIME_OPTIONS all the tests pass in the linux_x64 compile_time_options check.

Can we drop --define boringssl=fips?

@ggreenway
Copy link
Contributor

@lizan It seems the clang-asan build can't link properly with libc++ from LLVM 7.0.1. If I drop --define boringssl=fips from COMPILE_TIME_OPTIONS all the tests pass in the linux_x64 compile_time_options check.

Can we drop --define boringssl=fips?

No. This is the only CI coverage to ensure that fips builds.

ci/do_ci.sh Outdated
@@ -304,7 +304,7 @@ elif [[ "$CI_TARGET" == "bazel.compile_time_options" ]]; then

# Legacy codecs "--define legacy_codecs_in_integration_tests=true" should also be tested in
# integration tests with asan.
bazel_with_collection test "${BAZEL_BUILD_OPTIONS[@]}" --define wasm=wavm "${COMPILE_TIME_OPTIONS[@]}" -c dbg @envoy//test/integration/... --config=clang-asan --build_tests_only
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually this test does nothing... will be removed in #14105

Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@intel.com>
Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@intel.com>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Nov 25, 2020
Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@intel.com>
@moderation
Copy link
Contributor

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Nov 25, 2020
@lizan lizan merged commit 0f7952d into envoyproxy:master Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compile_time_options CI job fails with the latest Abseil lib
4 participants